Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MailboxManager and MailApiFetcher #914

Merged
merged 8 commits into from
Aug 10, 2023

Conversation

adrien-coye
Copy link
Contributor

@adrien-coye adrien-coye commented Aug 8, 2023

  • Split MailAPIFetcher for ease of use, maintainability and potential DI.

  • Also split MailboxManager for ease of use, maintainability and potential DI.

@adrien-coye adrien-coye self-assigned this Aug 9, 2023
@adrien-coye adrien-coye marked this pull request as ready for review August 9, 2023 09:03
@adrien-coye adrien-coye requested a review from a team as a code owner August 9, 2023 09:03
@adrien-coye adrien-coye marked this pull request as draft August 9, 2023 12:03
@adrien-coye adrien-coye changed the title Fix archive UI glitch Refactor MailboxManager and MailApiFetcher Aug 9, 2023
@adrien-coye adrien-coye marked this pull request as ready for review August 9, 2023 14:05
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@PhilippeWeidmann PhilippeWeidmann merged commit 4fd8ac0 into master Aug 10, 2023
5 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the fixArchiveUIGlitch branch August 10, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants